Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add rust support #1376

Merged
merged 96 commits into from
Dec 3, 2024
Merged

chore: add rust support #1376

merged 96 commits into from
Dec 3, 2024

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajewellamz ajewellamz requested a review from a team as a code owner September 19, 2024 11:49
@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

RitvikKapila
RitvikKapila requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits.

A few more comments:

DynamoDbEncryption/runtimes/rust/README.md Outdated Show resolved Hide resolved
DynamoDbEncryption/runtimes/rust/copy_externs.sh Show resolved Hide resolved
DynamoDbEncryption/runtimes/rust/examples/clientsupplier/client_supplier_example.rs Outdated Show resolved Hide resolved
DynamoDbEncryption/runtimes/rust/examples/clientsupplier/client_supplier_example.rs Outdated Show resolved Hide resolved
DynamoDbEncryption/runtimes/rust/examples/keyring/hierarchical_keyring.rs Outdated Show resolved Hide resolved
TestVectors/runtimes/rust/src/create_client.rs Show resolved Hide resolved
TestVectors/runtimes/rust/SkipLocal.txt Show resolved Hide resolved
TestVectors/runtimes/rust/src/create_client.rs Show resolved Hide resolved
TestVectors/runtimes/rust/src/create_client.rs Outdated Show resolved Hide resolved
TestVectors/runtimes/rust/src/lib.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

4 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

RitvikKapila
RitvikKapila approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is awesome!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@ajewellamz and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@ajewellamz ajewellamz merged commit 98ddfe9 into main Dec 3, 2024
39 checks passed
@ajewellamz ajewellamz deleted the ajewell/rust branch December 3, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitvikKapila RitvikKapila RitvikKapila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajewellamz @RitvikKapila @robin-aws @texastony